Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring changes #1257

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Jan 31, 2024

  1. Removed several unused includes and global using declarations in header files.
  2. Unify several includes to not use relative but global paths.
  3. Turn several macro constants into proper constexpr variables.
  4. As we only ever use the short version of the git hash, we now only store this short version. That makes the code simpler, as we don't have to manually shorten the hash before printing it. This also works with older indices, but those will report the full hash.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea905cc) 87.46% compared to head (a9acd9e) 87.45%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   87.46%   87.45%   -0.02%     
==========================================
  Files         307      304       -3     
  Lines       27771    27744      -27     
  Branches     3116     3115       -1     
==========================================
- Hits        24291    24263      -28     
+ Misses       2346     2344       -2     
- Partials     1134     1137       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions.

src/engine/OptionalJoin.h Outdated Show resolved Hide resolved
src/global/Constants.h Show resolved Hide resolved
src/engine/Distinct.h Outdated Show resolved Hide resolved
src/index/IndexImpl.cpp Outdated Show resolved Hide resolved
This change is technically not backwards compatible, it will print long hashes when using old indices
src/index/IndexImpl.cpp Outdated Show resolved Hide resolved
src/index/IndexImpl.cpp Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joka921 joka921 merged commit bebdadc into ad-freiburg:master Feb 2, 2024
17 of 18 checks passed
@RobinTF RobinTF deleted the small-refactoring-changes branch February 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants