-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small refactoring changes #1257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1257 +/- ##
==========================================
- Coverage 87.46% 87.45% -0.02%
==========================================
Files 307 304 -3
Lines 27771 27744 -27
Branches 3116 3115 -1
==========================================
- Hits 24291 24263 -28
+ Misses 2346 2344 -2
- Partials 1134 1137 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions.
This change is technically not backwards compatible, it will print long hashes when using old indices
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
using
declarations in header files.constexpr
variables.