Correctly merge planning trees for OPTIONAL JOIN and MINUS
#1777
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
- Coverage 90.04% 90.02% -0.02%
==========================================
Files 395 395
Lines 37909 37912 +3
Branches 4264 4264
==========================================
- Hits 34136 34132 -4
- Misses 2478 2481 +3
- Partials 1295 1299 +4 ☔ View full report in Codecov by Sentry. |
RobinTF
force-pushed
the
merge-filters
branch
from
88a0ab4 to
dba911a
Compare
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1454, but does not fix the underlying issue.
For regular joins the bitmasks that indicate which filters were already applied are merged, but this wasn't the case for optional joins and minus.