Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing macos installation #508

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Testing macos installation #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/macos_install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: macos (Installation)

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '**.md'
- 'docs/**'
push:
branches:
- main
paths-ignore:
- '**.md'
- 'docs/**'

permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
ubuntu-build:
runs-on: macos-latest
strategy:
matrix:
include:
- {shared: ON}
- {shared: OFF}
steps:
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
- name: Prepare
run: cmake -DBUILD_SHARED_LIBS=${{matrix.shared}} -DCMAKE_INSTALL_PREFIX:PATH=destination -B build
- name: Build
run: cmake --build build -j=2
- name: Install
run: cmake --install build
- name: Prepare test package
run: cmake -DCMAKE_INSTALL_PREFIX:PATH=../../destination -S tests/installation -B buildbabyada
- name: Build test package
run: cmake --build buildbabyada
- name: Run example
run: ./buildbabyada/main
1 change: 0 additions & 1 deletion cmake/ada-flags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_MACOSX_RPATH OFF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove this? @lemire

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, under macOS, CMake sets the MACOSX_RPATH property on all targets. If you do it manually, you should set CMAKE_MACOSX_RPATH to false. It appears that we do not set MACOSX_RPATH, so we either need to do so, or to leave CMAKE_MACOSX_RPATH to its default value (ON).

https://cmake.org/cmake/help/latest/variable/CMAKE_MACOSX_RPATH.html

Note that this is not normally an issue because we rarely use dynamic libraries under macOS.


find_program(CCACHE_FOUND ccache)
if(CCACHE_FOUND)
Expand Down
Loading