In functions using ada_owned_string, return ada_owned_string instead of &str #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned_string ada_owned_string is supposed to be cleared manually. This was not being done currently. Instead an internal reference to the memory was being returned by these functions. This led to us being unable to delete the memory out of fear of invalidating the &str present in user space. By returning ada_owned_string, this issue is resolved and the memory leaks no longer happen in library space. Old &str can still be accessed using as_ref. BREAKING CHANGE: Functions using ada_owned_string now return ada_owned_string instead of &str. Memory leaks no longer happen in library space. Old &str can still be accessed using as_ref.
Clears the memory after the ada_owned_string goes out of scope. This ensures that ada_owned_string is cleared in user space. BREAKING CHANGE: ada_owned_string was previously not freed upon going out of scope. Now it is.
anonrig
requested changes
May 20, 2024
|
Aah I actually did implement the same and then yeeted everything back 30 minutes ago because of a few concerns
I can re-implement the same. It's just a few undos |
Makes it possible to convert ada_owned_string to ToString
…_string to String Ensures that ada_owned_string does not leak to user space and allows us to make internal breaking changes to its implementation. Fixes all leak issue. Causes small performance downgrades due to copies. Causes functions to be usable only if std is enabled. BREAKING CHANGE: Return type changed from ada_owned_string->String. Functions now work only with std feature enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Advantages
Disadvantages
This would lead to the freeing of memory upon its going out of scope breaking existing code.
This behaviour is probably more Rust-like but breaks user-space.
The alternative is to not impement Drop and it could be done.
However, this would make it user space's responsibility and hence not exactly an ideal behaviour
This can be resolved by probably implementing conversion functions if needed for Display, to_string etc. in std mode for end-user ease.
Another approach
Would lead to a major breaking change.
The approach would lead to all 3 functions no longer working in no-std mode.
That is probably not ideal.
Closes #63