lowlight bugfix in getLuminosity(TSL2591_VISIBLE) when there are low … #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…light situations, it is possible, that the ir photosiode returns a higher value than the fullspectrum photosiode. if that happens, the calculated result was a low negative numver which results in a high positive number if returned as an uint
|
I'm not sure why the checks have failed. I've double-checked the code again and I cannot see any issue. Furthermore my code is running fine on my installation. |
|
I've changed one more thing There is an open issue about negative Lux values. Therefore the method first checks if the full value is greater than the ir value and if the full value isn't zero. this should fix that issue. |
|
@ladyada have you had a chance to look into this yet? |
|
nope! we wouldn't review until there are no merge conflicts and the actions CI passes |
|
What about now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in low light situations, it is possible, that the ir photodiode returns a higher value than the fullspectrum photodiode. if that happens, the calculated result was a low negative number which results in a high positive number if returned as an uint.
e.g. if the fullspec diode returns 0 and the ir diode returns 1, the calculated result for the visible value was -1. if -1 is stored in an uint16_t it results as an 0xFFFE.
The Scope of the change is to prevent the getLuminosity(TSL2591_VISIBLE) method to return 0xFFFF or 0xFFFE in low light situations, when the IR diode can return values greater then the ones from the fullspec diode.
Describe any known limitations with your change. There are no known limitations.