Fix GUID serialization function

adalinesimonian · Jun 29, 2015 · 17ed311 · 17ed311
1 parent 229cf97
commit 17ed311
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/lib/adauth.js b/lib/adauth.js
@@ -424,10 +424,20 @@ ADAuth.prototype._binarySIDToString = function (binarySID) {
 
 ADAuth.prototype._binaryGUIDToString = function (binaryGUID) {
   var guid = '{';
+  var idx;
   for (var i = 0; i < binaryGUID.length; i++) {
-    guid += (binaryGUID[i] < 0x10) ? '0' : '' +
-            binaryGUID[i].toString(16) +
-            (i === 3 || i === 5 || i === 7 || i === 9) ? '-' : '';
+    if (i < 4) {
+      idx = 3 - i;
+    } else if (i === 4 || i === 6) {
+      idx = i + 1;
+    } else if (i === 5 || i === 7) {
+      idx = i - 1;
+    } else {
+      idx = i;
+    }
+    guid += ((binaryGUID[idx] < 0x10) ? '0' : '') +
+            binaryGUID[idx].toString(16) +
+            ((i === 3 || i === 5 || i === 7 || i === 9) ? '-' : '');
   }
   return guid + '}';
 };