Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FDS how-to guides #2332

Merged
merged 27 commits into from
Sep 20, 2023
Merged

Add FDS how-to guides #2332

merged 27 commits into from
Sep 20, 2023

Conversation

adam-narozniak
Copy link
Member

@adam-narozniak adam-narozniak commented Sep 11, 2023 •
edited
Loading

Add Flower Dataset How-To guides

  • TensorFlow,
  • PyTorch,
  • Numpy.

@adam-narozniak adam-narozniak changed the title Add how-to guides Add FDS how-to guides Sep 11, 2023
danieljanes
danieljanes requested changes Sep 12, 2023
View reviewed changes
datasets/doc/source/how-to.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-tf.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-torch.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-numpy.rst Outdated Show resolved Hide resolved
danieljanes
danieljanes requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments

datasets/doc/source/how-to-install-flwr-datasets.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-install-flwr-datasets.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-install-flwr-datasets.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-install-flwr-datasets.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-numpy.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-pytorch.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-pytorch.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-pytorch.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-tensorflow.rst Outdated Show resolved Hide resolved
datasets/doc/source/how-to-use-with-tensorflow.rst Outdated Show resolved Hide resolved
adam-narozniak and others added 12 commits September 20, 2023 10:16
@adam-narozniak @danieljanes
Fix the pip install instruction in how-to-install
a2911b4 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Fix the description on the vision datasets
82f2bd0 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Fix the formatting for the audio datasets (no capitalization)
18cf320 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Add new line after the import in how-to-use-with-numpy
9f28c62 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Update datasets/doc/source/how-to-use-with-numpy.rst
5820434 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Use we instead of I
44c335f 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Update datasets/doc/source/how-to-use-with-pytorch.rst
bb15d9b 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Update datasets/doc/source/how-to-use-with-tensorflow.rst
1473f00 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Update datasets/doc/source/how-to-use-with-pytorch.rst
c70aa41 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Update datasets/doc/source/how-to-use-with-pytorch.rst
913880e 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak @danieljanes
Update datasets/doc/source/how-to-use-with-tensorflow.rst
33aa84e 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak
Fix the bash code formatting
7db29a0
@danieljanes danieljanes enabled auto-merge (squash) September 20, 2023 10:30
@danieljanes danieljanes merged commit 36eb11c into main Sep 20, 2023
28 checks passed
@danieljanes danieljanes deleted the fds-docs-how-to branch September 20, 2023 10:35
tanertopal added a commit that referenced this pull request Sep 22, 2023
@tanertopal
Merge branch 'main' of github.com:adap/flower
e90c5df 
* 'main' of github.com:adap/flower:
  Fix default contiguous value in IidPartitioner (#2406)
  Update FDS docs index (#2337)
  Add TensorFlow integration tests with FDS (#2350)
  Add paths specification to CI triggers for FDS (#2399)
  Add FDS how-to guides (#2332)
  Add Flower Datasets tests as GitHub workflow (#2345)
  Fix the reference API documentation (#2397)
  Add FDS tutorial docs (#2375)
  Update tutorial-series-what-is-federated-learning.ipynb (#2396)
  Fix missing square in proximal term of FedProx baseline (#2210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-narozniak @danieljanes