Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyTorch integration tests with FDS #2351

Merged
merged 21 commits into from
Dec 20, 2023
Merged

Conversation

adam-narozniak
Copy link
Member

No description provided.

@adam-narozniak adam-narozniak marked this pull request as ready for review September 15, 2023 10:26
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the same changes in the other two integration test PRs (if applicable)

datasets/integration_tests/pytorch/pyproject.toml Outdated Show resolved Hide resolved
datasets/integration_tests/pytorch/pytorch_test.py Outdated Show resolved Hide resolved
Copy link
Member

@charlesbvll charlesbvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanertopal tanertopal enabled auto-merge (squash) November 10, 2023 09:01
@adam-narozniak adam-narozniak self-assigned this Dec 20, 2023
@tanertopal tanertopal dismissed danieljanes’s stale review December 20, 2023 15:31

Requested changes where added.

@tanertopal tanertopal merged commit aded3e0 into main Dec 20, 2023
30 checks passed
@tanertopal tanertopal deleted the fds-pytorch-integration-tests branch December 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants