Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more datasets in FDS #2392

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Enable more datasets in FDS #2392

merged 4 commits into from
Oct 9, 2023

Conversation

adam-narozniak
Copy link
Member

@adam-narozniak adam-narozniak commented Sep 19, 2023

Relax the ValueError by changing to the warning.warn when the user wants to use the dataset that was not tested.

Changes

  • Change the ValueError to warning.warn
  • Adjust the tests to check if the code warns in case of untested datasets.

Motivation

By doing that, we allow

  • many tabular datasets the library currently supports (but wouldn't if the ValueError was raised)
  • vision datasets that have not been tested by us yet,
  • potential contributions.

Questions

The way of keeping the reference to the tested datasets might be different that proposed by me - keep them in the list that corresponds to the categories in HF Hub.

@danieljanes danieljanes enabled auto-merge (squash) October 9, 2023 19:06
@danieljanes danieljanes merged commit 8fbfaf8 into main Oct 9, 2023
29 checks passed
@danieljanes danieljanes deleted the fds-enable-more-datasets branch October 9, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants