-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NaturalIdPartitioner to FDS #2404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
danieljanes and
tanertopal
as code owners
September 25, 2023 13:06
adam-narozniak
changed the title
Add IdPartitioner to FDS
Add NaturalIdPartitioner to FDS
Nov 7, 2023
danieljanes
requested changes
Nov 7, 2023
datasets/flwr_datasets/partitioner/natural_id_partitioner_test.py
Outdated
Show resolved
Hide resolved
datasets/flwr_datasets/partitioner/natural_id_partitioner_test.py
Outdated
Show resolved
Hide resolved
danieljanes
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are many datasets in which the field, like client id, writer id or speaker id, exists, and they can be divided based on this canonical form. However, the division of a dataset in such a way is not currently available in Flower Datasets.
Proposal
Add a new partitioner,
NaturalIdPartitioner
that enables dividing datasets based on this canonical (already present) division. Each group is associated with a unique value in the columns specified by a user.Example usage