Make the split keyword optional for load_partition #2423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, when you create the
FederatedDataset
object and want to load a partition, you need to do the following.Yet it is clear that there is only one instance of
Partitioner
. Therefore, the call can be simplified. To say it differently, if when specyfing the split keyword in theload_partitition(idx=idx, split="train")
train
is the only possibility since you denote which partitioner will be used and only a single partitioner was used.Proposal
Make the split keyword optional for
load_partition
in case of having just one partitioner:Explanation
This PR does the following:
FederatedDataset
,Datasets
objects).