Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++ workflow file #2528

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add C++ workflow file #2528

merged 3 commits into from
Oct 23, 2023

Conversation

charlesbvll
Copy link
Member

Issue

Description

No tests were made on the C++ SDK.

Related issues/PRs

N/A

Proposal

Explanation

Add tests for C++ to the CI.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@tanertopal
Copy link
Member

tanertopal commented Oct 23, 2023

@charlesbvll This PR might create a lot of cache eviction as we have a 10GB total limit for caches on GitHub actions.

See:

I suggest using cache save only on the main branch and cache restore on the main and PR branches.

See:

@charlesbvll
Copy link
Member Author

@charlesbvll This PR might create a lot of cache eviction as we have a 10GB total limit for caches on GitHub actions.

See:

I suggest using cache save only on the main branch and cache restore on the main and PR branches.

See:

@tanertopal Thanks for the feedback! I updated the workflow file

@tanertopal tanertopal merged commit baaa8c6 into main Oct 23, 2023
26 checks passed
@tanertopal tanertopal deleted the add-cpp-ci-workflow branch October 23, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants