Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FedXgbNnAvg strategy doc to reference the right paper #2542

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Fix FedXgbNnAvg strategy doc to reference the right paper #2542

merged 5 commits into from
Nov 20, 2023

Conversation

gfmota
Copy link
Contributor

@gfmota gfmota commented Oct 29, 2023

Issue 2380

Description

Fixes FedXgbNnAvg strategy doc referencing the wrong paper

Related issues/PRs

Issue and solution discussed here #2380

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

jafermarq
jafermarq previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect! thanks @gfmota

@jafermarq jafermarq added the documentation Improvements or additions to documentation label Nov 6, 2023
@jafermarq jafermarq enabled auto-merge (squash) November 6, 2023 19:06
@jafermarq jafermarq self-assigned this Nov 20, 2023
auto-merge was automatically disabled November 20, 2023 18:43

Head branch was pushed to by a user without write access

jafermarq
jafermarq approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @gfmota

@jafermarq jafermarq enabled auto-merge (squash) November 20, 2023 22:00
@tanertopal tanertopal disabled auto-merge November 20, 2023 22:11
@tanertopal tanertopal enabled auto-merge (squash) November 20, 2023 22:11
tanertopal
tanertopal approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you!

@tanertopal tanertopal merged commit 10bfc33 into adap:main Nov 20, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees

@jafermarq jafermarq

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfmota @tanertopal @jafermarq