Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++ SDK package in the C++ quickstart example #2545

Merged
merged 20 commits into from
Nov 8, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Oct 30, 2023

Issue

Description

Currently you need the local SDK files to be able to compile the quickstart-cpp example, meaning it can't be run in a standalone fashion.

Related issues/PRs

N/A

Proposal

Explanation

Use FetchContent to get the C++ SDK dependencies necessary for the quickstart-cpp example. Also provides a compile argument to use the local source instead (useful for tests) and use it in the CI workflow.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review November 6, 2023 21:47
@danieljanes danieljanes merged commit 82c772d into main Nov 8, 2023
27 checks passed
@danieljanes danieljanes deleted the use-fetch-cpp-example branch November 8, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants