-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fds automatic docs #2562
Merged
Merged
Fds automatic docs #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change to follow only the docs from __all__
adam-narozniak
requested review from
danieljanes and
tanertopal
as code owners
November 16, 2023 09:32
charlesbvll
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
danieljanes
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, the documentation process is done manually. It is prone to errors by not adding the created code (that might be documented).
Description
The only role of the currently working scripts is just to transform the .rst files into HTML files. The creation of the .rst files is assumed to be manual.
Proposal
Use the
sphinx-autosummary
to fully automatize the docs building process.Explanation
sphinx-autosummary
enable automatic recursive creation of the .rst files (by filling it withsphinx-autodoc
output). It additionally provides a summary table with a one-sentence summary and a link to the documentation. (see picture below).This PR introduces:
a. Excludes the test.py files
b. Dictates how the files look.
c. Tells that the docs should only follow the code in __all __
Note: this PR does not introduce storing the .rst files with the documentation (and deletes the previous single file)
Preview
Summary tables
Documentation page: FederatedDataset
Toggle buttons
Shortcommings