Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware #2580

Merged
merged 124 commits into from
Dec 19, 2023
Merged

Middleware #2580

merged 124 commits into from
Dec 19, 2023

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Nov 7, 2023 •
edited
Loading

Folder Structure

  • /client
    • /middleware
      • __init__.py
      • utils.py
      • utils_test.py

Changes

  • Added to middleware/utils.py the make_fc function, which wraps middleware layers around a core app.
  • Added definition of Layer to client/typing.py
  • Added unit tests for the make_fc function
  • Modified Flower class to enable middleware layers.

danieljanes and others added 30 commits September 19, 2023 20:25
@danieljanes
Decouple client and app
4886c77
@danieljanes
Merge branch 'main' into decouple-client
fb8ba3d
@danieljanes
Merge branch 'main' into decouple-client
fca2187
@danieljanes
Merge branch 'main' into decouple-client
5e5fec6
@danieljanes
Merge branch 'main' into decouple-client
c3e82b7
@danieljanes
Shorten line
1223f90
@danieljanes
Merge branch 'main' into decouple-client
555d89a
@danieljanes
Add comments to main client loop
a7c57d6
@danieljanes
Refactor start_client
9a20a0c
@danieljanes
Merge branch 'main' into decouple-client
d65601b
@danieljanes
Merge branch 'refactor-start-client' into decouple-client
82df0a3
@danieljanes
Format code
32e4973
@danieljanes
Add type hint
11bf509
@danieljanes
Merge branch 'refactor-start-client' into decouple-client
d097096
@charlesbvll
Test with Iterator
a1a647a
@charlesbvll
Working solution (I think)
ce2bbb8
@charlesbvll
Fix imports
7617335
@danieljanes
Merge branch 'refactor-start-client' into decouple-client
d9a7318
@danieljanes
Merge branch 'main' into decouple-client
46acb9d
@danieljanes
Merge branch 'main' into decouple-client
e61c91a
@danieljanes
Move task execution into Flower app
156aad0
@danieljanes
Enable --app in flower-client
a47a760
@danieljanes
Merge branch 'main' into decouple-client
77bfc04
@danieljanes
Add comments to start_client
90058f9
@danieljanes
Handle control messages in a separate function
86c1473
@danieljanes
Change comment
9bc1349
@danieljanes
Merge branch 'refactor-start-client-comments' into refactor-start-cli…
ee87393 
…ent-control-message
@danieljanes
Update comments
1691340
@danieljanes
Update comments
7d732e9
@danieljanes
Format
9f6472f
danieljanes
danieljanes requested changes Dec 18, 2023
View reviewed changes
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/how-to-use-middleware.rst Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
danieljanes
danieljanes requested changes Dec 18, 2023
View reviewed changes
src/py/flwr/client/middleware/utils.py Outdated Show resolved Hide resolved
src/py/flwr/client/flower.py Outdated Show resolved Hide resolved
src/py/flwr/client/middleware/utils.py Outdated Show resolved Hide resolved
src/py/flwr/client/middleware/__init__.py Outdated Show resolved Hide resolved
src/py/flwr/client/middleware/utils.py Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) December 19, 2023 13:54
@danieljanes danieljanes merged commit 251fdf1 into main Dec 19, 2023
16 of 27 checks passed
@danieljanes danieljanes deleted the middleware branch December 19, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panh99 @danieljanes @jafermarq @charlesbvll