Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fds fix missing __all__ in inits #2599

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Fds fix missing __all__ in inits #2599

merged 3 commits into from
Nov 15, 2023

Conversation

adam-narozniak
Copy link
Contributor

Issue

Not all classes/packages in Flower Datasets are exposed via __all __ in __init __ files.

Proposal

  • Expose the missging packages in the main __init __ files
  • Create a resplitter package and expose the functionality from there.

@adam-narozniak adam-narozniak changed the title Fds fix all in inits Fds fix missing __all__ in inits Nov 15, 2023
@danieljanes danieljanes merged commit d00a579 into main Nov 15, 2023
29 checks passed
@danieljanes danieljanes deleted the fds-fix-all-in-inits branch November 15, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-narozniak @danieljanes