Xgboost-quickstart example #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
requested changes
Nov 17, 2023
Co-authored-by: Daniel J. Beutel <[email protected]>
Co-authored-by: Daniel J. Beutel <[email protected]>
danieljanes
reviewed
Nov 17, 2023
Comment on lines
52
to
53
| # Let's use the first partition as an example | ||
| partition = fds.load_partition(idx=0, split="train") |
There was a problem hiding this comment.
Should we add the possibility to load a specific partition by providing --node-id 0 or --node-id 1? And then use IidPartitioner(num_partitions=2) above?
There was a problem hiding this comment.
ok, i'll pull back the arguments parser only for --node-id
danieljanes
reviewed
Nov 17, 2023
danieljanes
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
We need a simpler quick-start example for XGBoost, which allows users to get a quick idea of how to use XGBoost in Flower.
Proposal
In this example, we simply the data partitioning part, and remove the customised experimental settings. We only use two clients for the training. The evaluation is conducted on clients' hold-out test set.
Note
After bagging strategy has been moved to the core framework, this PR, we need to change the server code here to use the strategy from the core framework.