flower-via-docker-compose example

[NikosVlachakis]

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

• Implement proposed change
• Write tests
• Update documentation
• Update changelog
• Make CI checks pass
• Ping maintainers on Slack (channel #contributions)

Any other comments?

[jafermarq]

Hi @NikosVlachakis,

This is great :)

I left some comments below. In this first review i mostly focused on following the steps in the readme to run the code. The grafana dashboard is not populated with charts automatically. I believe the uid needs to be fixed both in the dashboard .json and the prometheus & grafana configs.

It would be ideal if could add a couple of links to some resources (maybe a grafana tutorial in their docs) so people running the example can look into the reference material in case they want to expand how the dashboard looks like or learn more about grafana. Having links to prometheus and cadvisor docs is also good.

I like how the docker compose file is generated.

[jafermarq]

@Robert-Steiner, please take a look at this example when you have some time. It looks completed to me eyes. But maybe you have some suggestions regarding how docker/docker-compose (or even grafana/prometheus) that we should incorporate to make this example more future proof.

[jafermarq]

@NikosVlachakis, this looks great!

[danieljanes]

Great PR, looking forward to merging this soon!

Just one small detail: for the images in public, could we remove them and link them similar to how we do it with the Flower logo?

[NikosVlachakis]

Great PR, looking forward to merging this soon!

Just one small detail: for the images in public, could we remove them and link them similar to how we do it with the Flower logo?

Hey Daniel, thank you.
Do you mean to remove the entire public folder and use external (public) links for each image?

[danieljanes]

Do you mean to remove the entire public folder and use external (public) links for each image?

Yes, exactly. When we link to images, we don't need to commit them to the repo, and it's clear where they come from for users.

[NikosVlachakis]

Do you mean to remove the entire public folder and use external (public) links for each image?

Yes, exactly. When we link to images, we don't need to commit them to the repo, and it's clear where they come from for users.

Ok, I see, I removed the public folder and created publicly available urls for each image.