Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images in example docs #2630

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Fix images in example docs #2630

merged 6 commits into from
Nov 23, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Nov 23, 2023

Issue

Description

Currently images from examples README files are not displayed in the examples docs.

Related issues/PRs

N/A

Proposal

Explanation

Automatically copy the images from the _static folders of examples.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review November 23, 2023 16:52
jafermarq
jafermarq previously approved these changes Nov 23, 2023
dev/update-examples.sh Outdated Show resolved Hide resolved
@tanertopal tanertopal enabled auto-merge (squash) November 23, 2023 20:45
@tanertopal tanertopal merged commit 01fdba4 into main Nov 23, 2023
27 checks passed
@tanertopal tanertopal deleted the fix-examples-docs-images branch November 23, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants