Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make flower-client HTTPS by default #2636

Merged
merged 23 commits into from
Nov 28, 2023
Merged

Make flower-client HTTPS by default #2636

merged 23 commits into from
Nov 28, 2023

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Nov 25, 2023 •
edited
Loading

  • Added --insecure and --root-certificates arguments for flower-client
  • Modified run_client function to run with HTTPS-enabled by default.
  • Added to all client.py in E2E tests a Flower callable.
  • Updated e2e/test_driver.sh to run clients via flower-client.
  • Added insecure arg to start_client, start_numpy_client, connection, and create_channel.

Note

  • flower-client will start with HTTPS-enabled by default.
  • start_client and start_numpy_client will still start in the insecure mode by default for backward compatibility.
  • flower-client will fail when both --insecure and --root-certificates are set.

@danieljanes danieljanes merged commit 875b6c7 into main Nov 28, 2023
@danieljanes danieljanes deleted the https-flower-client branch November 28, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes danieljanes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @tanertopal @danieljanes