Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vertical-fl example #2655

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix vertical-fl example #2655

merged 2 commits into from
Nov 29, 2023

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Nov 28, 2023 •
edited
Loading

A couple of minor fixes: Install flwr[simulation] and fix saving of results.

@jafermarq
Copy link
Contributor Author

is there something to do for #2653? in this PR?

@jafermarq jafermarq marked this pull request as ready for review November 28, 2023 20:27
charlesbvll
charlesbvll approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@charlesbvll charlesbvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jafermarq jafermarq added the part: examples Add or update a Flower example label Nov 28, 2023
@jafermarq jafermarq enabled auto-merge (squash) November 28, 2023 20:35
@jafermarq jafermarq merged commit 02bb3ba into main Nov 29, 2023
27 checks passed
@jafermarq jafermarq deleted the fix-vertical-fl-example branch November 29, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbvll charlesbvll charlesbvll approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
part: examples Add or update a Flower example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jafermarq @danieljanes @charlesbvll