Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --insecure to start_server and rename certificates to credentials #2663

Closed
wants to merge 11 commits into from
Closed

Add --insecure to start_server and rename certificates to credentials #2663

wants to merge 11 commits into from

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Nov 29, 2023 •
edited
Loading

  • Renamed certificates to credentials in start_server, flower-server, and all other related code, to align with gRPC APIs
  • Added insecure arg to start_server.
  • Added sys.exit when both insecure and credentials are set.

@Robert-Steiner Robert-Steiner mentioned this pull request Dec 8, 2023
Merged
@danieljanes danieljanes marked this pull request as draft December 22, 2023 12:50
@danieljanes danieljanes changed the title Update flower-server and start_server Add --insecure to start_server and rename certificates to credentials Dec 22, 2023
@panh99 panh99 closed this Sep 10, 2024
@panh99 panh99 deleted the update-flower-server branch September 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@jafermarq jafermarq Awaiting requested review from jafermarq jafermarq will be requested when the pull request is marked ready for review jafermarq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@panh99