-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI workflow for building and releasing server docker images #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
force-pushed
the
docker-server-ci
branch
26 times, most recently
from
December 5, 2023 15:58
9fed91a
to
e27c7cb
Compare
Robert-Steiner
force-pushed
the
docker-server-ci
branch
from
December 5, 2023 15:58
e27c7cb
to
b783012
Compare
Robert-Steiner
changed the title
add server ci workflow
Add CI workflow for building and releasing server docker images
Dec 5, 2023
Robert-Steiner
requested review from
danieljanes and
tanertopal
as code owners
December 5, 2023 16:39
tanertopal
approved these changes
Dec 6, 2023
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Add CI workflow for building and releasing server docker images
Description
The PR adds a reusable workflow to build server docker images for various platforms. The images are pushed to dockerhub. Currently the workflow can only be triggered via a
workflow_dispatch
event. There are two ways to create such an event. You can use UI to create one or you can use thegh
cli tool. Later the workflow will also run as part of the release workflow.The workflow builds and releases images for
arm64
andamd64
. We are currently not releasingarm/v7
due to difficulties compiling thecryptography
package (see pyca/cryptography#7891). The default python version for the server image is3.11
.Any other comments?