Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow for building and releasing server docker images #2682

Merged
merged 13 commits into from
Dec 6, 2023

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Dec 4, 2023

Issue

Add CI workflow for building and releasing server docker images

Description

The PR adds a reusable workflow to build server docker images for various platforms. The images are pushed to dockerhub. Currently the workflow can only be triggered via a workflow_dispatch event. There are two ways to create such an event. You can use UI to create one or you can use the gh cli tool. Later the workflow will also run as part of the release workflow.

The workflow builds and releases images for arm64 and amd64. We are currently not releasing arm/v7 due to difficulties compiling the cryptography package (see pyca/cryptography#7891). The default python version for the server image is 3.11.

Any other comments?

  • Dockerhub does not support immutable tags. Therefore it is possible to override an existing tag. Should we add a check to prevent that?
  • Later we can also add the possibility to publish images via a custom tag. Might be useful if we want to test a certain branch, feature, etc.
  • I was not able to test the workflow_dispatch event because we can only trigger it once it is merged.
  • workflow run: https://github.com/adap/flower/actions/runs/7102820035
  • https://hub.docker.com/r/flwr/server/tags

@Robert-Steiner Robert-Steiner force-pushed the docker-server-ci branch 26 times, most recently from 9fed91a to e27c7cb Compare December 5, 2023 15:58
@Robert-Steiner Robert-Steiner changed the title add server ci workflow Add CI workflow for building and releasing server docker images Dec 5, 2023
@Robert-Steiner Robert-Steiner marked this pull request as ready for review December 5, 2023 16:39
@tanertopal
Copy link
Member

lgtm!

@tanertopal tanertopal enabled auto-merge (squash) December 6, 2023 09:26
@tanertopal tanertopal merged commit 30bc20c into main Dec 6, 2023
27 checks passed
@tanertopal tanertopal deleted the docker-server-ci branch December 6, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants