Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DriverClientProxy work with RecordSet and task_type. #2853

Merged
merged 12 commits into from
Jan 29, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Jan 25, 2024

  • Updated DriverClientProxy so that it converts/retrieves legacy *Ins/*Res to/from RecordSet and task_type.
  • Updated the unit tests accordingly.

This PR is based on #2842.

@panh99 panh99 changed the base branch from main to replace-fwd-bwd-flowercontext January 27, 2024 11:03
@panh99 panh99 marked this pull request as ready for review January 27, 2024 11:18
@panh99 panh99 marked this pull request as draft January 27, 2024 11:18
@panh99 panh99 changed the base branch from replace-fwd-bwd-flowercontext to main January 27, 2024 11:31
@panh99 panh99 marked this pull request as ready for review January 27, 2024 11:39
@panh99 panh99 closed this Jan 27, 2024
@panh99 panh99 reopened this Jan 27, 2024
@danieljanes danieljanes changed the base branch from main to replace-fwd-bwd-flowercontext January 27, 2024 15:50
danieljanes
danieljanes previously approved these changes Jan 29, 2024
@panh99 panh99 changed the base branch from replace-fwd-bwd-flowercontext to main January 29, 2024 09:57
@panh99 panh99 dismissed danieljanes’s stale review January 29, 2024 09:57

The base branch was changed.

@danieljanes danieljanes changed the base branch from main to replace-fwd-bwd-flowercontext January 29, 2024 10:23
@danieljanes danieljanes changed the base branch from replace-fwd-bwd-flowercontext to main January 29, 2024 10:25
@danieljanes danieljanes changed the base branch from main to replace-fwd-bwd-flowercontext January 29, 2024 10:39
@danieljanes danieljanes merged commit 599a974 into replace-fwd-bwd-flowercontext Jan 29, 2024
28 checks passed
@danieljanes danieljanes deleted the recordset-driverproxy branch January 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants