Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets:skip) Remove pyarrow version pin #4573

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

adam-narozniak
Copy link
Member

@adam-narozniak adam-narozniak commented Nov 22, 2024

Issue

In #3817 we pinned the pyarrow version to avoid the pypi discoverability problems for a newer than 16.1.0 pyarrow version (which made the whole CI fail - that was the reason for the temporal version pin).

Proposal

Unpin the pyarrow version. (it was also noticed by a user with an older VS Code that this old version does not work for him.)

@adam-narozniak adam-narozniak changed the title fix(datasets) Unpin pyarrow version fix(datasets:skip) Unpin pyarrow version Nov 22, 2024
@adam-narozniak adam-narozniak changed the title fix(datasets:skip) Unpin pyarrow version fix(datasets:skip) Remove pyarrow version pin Nov 22, 2024
@tanertopal tanertopal enabled auto-merge (squash) November 22, 2024 16:14
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit e23c12f into main Nov 22, 2024
58 checks passed
@tanertopal tanertopal deleted the fds-unpin-pyarrow-version branch November 22, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants