fix setup on MacOS and add tests

adbar · Dec 21, 2023 · aaf49c4 · aaf49c4
1 parent d31c8d7
commit aaf49c4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -17,6 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
+        # https://github.com/actions/python-versions/blob/main/versions-manifest.json
         python-version: ["3.9", "3.11"]
         env: [{ MINIMAL: "true" }, { MINIMAL: "false" }]
         include:
@@ -27,12 +28,16 @@ jobs:
             python-version: 3.7
           - os: macos-latest
             python-version: 3.8
+          - os: macos-latest
+            python-version: "3.10"
+          - os: macos-latest
+            python-version: "3.12"
           - os: windows-latest
             python-version: 3.8
           - os: ubuntu-latest
             python-version: "3.10"
           - os: ubuntu-latest
-            python-version: "3.12-dev"
+            python-version: "3.12"
     steps:
     # Python and pip setup
     - name: Set up Python ${{ matrix.python-version }}

diff --git a/setup.py b/setup.py
@@ -115,8 +115,9 @@ def get_long_description():
         "htmldate >= 1.6.0",
         "importlib_metadata; python_version < '3.8'",
         "justext >= 3.0.0",
-        "lxml >= 4.9.3 ; platform_system != 'Darwin'",
-        "lxml == 4.9.2 ; platform_system == 'Darwin'",
+        # see tests on Github Actions
+        "lxml == 4.9.2 ; platform_system == 'Darwin' and python_version <= '3.8'",
+        "lxml >= 4.9.4 ; platform_system != 'Darwin' or python_version > '3.8'",
         "urllib3 >= 1.26, < 2; python_version < '3.7'",
         "urllib3 >= 1.26, < 3; python_version >= '3.7'",
     ],