Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validated-button): yield customizable button #705

Merged
merged 6 commits into from
Jan 5, 2022

Conversation

derrabauke
Copy link
Contributor

No description provided.

@derrabauke derrabauke requested review from anehx and czosel December 22, 2021 09:37
@derrabauke derrabauke force-pushed the custom-form-button branch 2 times, most recently from 94c997a to 30d9c27 Compare December 22, 2021 10:38
@derrabauke derrabauke force-pushed the custom-form-button branch 2 times, most recently from 9e8ec44 to f118367 Compare December 23, 2021 12:03
@derrabauke derrabauke force-pushed the custom-form-button branch 4 times, most recently from 35986f8 to b75c022 Compare December 23, 2021 15:29
@derrabauke
Copy link
Contributor Author

While using ember-one-way-select we encounter the problem, that hasBlock is deprecated as of 3.x and it will fail our test scenario ember-release which matches 4.0.x
Therefore I opended a PR on the ember-one-way-select addon: DockYard/ember-one-way-select#21

@derrabauke derrabauke marked this pull request as draft December 24, 2021 10:03
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@czosel czosel marked this pull request as ready for review January 4, 2022 13:20
@derrabauke derrabauke merged commit 18d141e into adfinis:main Jan 5, 2022
velrest pushed a commit that referenced this pull request Jan 6, 2022
# [5.1.0](v5.0.0...v5.1.0) (2022-01-06)

### Bug Fixes

* **husky:** disable commitlint in CI ([#719](#719)) ([0da70e9](0da70e9))

### Features

* **validated-button:** yield customizable button ([#705](#705)) ([18d141e](18d141e))
* **validated-input:** replace select component ([#718](#718)) ([ac7969a](ac7969a))
@velrest
Copy link
Contributor

velrest commented Jan 6, 2022

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derrabauke derrabauke deleted the custom-form-button branch November 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants