refactor: replace *args, **kwargs with _{argname} wherever possible

while editing code to make ruff happy about unused variables i ended up replacing unused args/kwargs with *args, **kwargs, this commit reverts this to use the argname with an underscore wherever possible

timed/authentication.py

@@ -12,7 +12,7 @@
 
 
 class TimedOIDCAuthenticationBackend(OIDCAuthenticationBackend):
-    def get_introspection(self, access_token, *args, **kwargs):
+    def get_introspection(self, access_token, _id_token, _payload):
         """Return user details dictionary."""
         basic = base64.b64encode(
             f"{settings.OIDC_RP_INTROSPECT_CLIENT_ID}:{settings.OIDC_RP_INTROSPECT_CLIENT_SECRET}".encode()
@@ -57,7 +57,7 @@ def get_userinfo_or_introspection(self, access_token):
                     return claims
             raise AuthenticationFailed from exc
 
-    def get_or_create_user(self, access_token, *args, **kwargs):
+    def get_or_create_user(self, access_token, _id_token, _payload):
         """Verify claims and return user, otherwise raise an Exception."""
         claims = self.get_userinfo_or_introspection(access_token)
 

timed/employment/views.py

@@ -101,14 +101,14 @@ def get_queryset(self):
         return queryset
 
     @action(methods=["get"], detail=False)
-    def me(self, request, *args, **kwargs):
+    def me(self, request, _pk=None):
         self.object = get_object_or_404(get_user_model(), pk=request.user.id)
         serializer = self.get_serializer(self.object)
 
         return Response(serializer.data)
 
     @action(methods=["post"], detail=True)
-    def transfer(self, *args, **kwargs):
+    def transfer(self, _request, pk=None):  # noqa: ARG002
         """Transfer worktime and absence balance to new year.
 
         It will skip any credits if a credit already exists on the first

timed/permissions.py

@@ -18,50 +18,50 @@ def has_object_permission(self, _request, _view, obj):
 class IsReadOnly(BasePermission):
     """Allows read only methods."""
 
-    def has_permission(self, request, *args, **kwargs):
+    def has_permission(self, request, _view):
         return request.method in SAFE_METHODS
 
-    def has_object_permission(self, request, view, *args, **kwargs):
+    def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 
 class IsDeleteOnly(BasePermission):
     """Allows only delete method."""
 
-    def has_permission(self, request, *args, **kwargs):
+    def has_permission(self, request, _view):
         return request.method == "DELETE"
 
-    def has_object_permission(self, request, view, *args, **kwargs):
+    def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 
 class IsNotDelete(BasePermission):
     """Disallow delete method."""
 
-    def has_permission(self, request, *args, **kwargs):
+    def has_permission(self, request, _view):
         return request.method != "DELETE"
 
-    def has_object_permission(self, request, view, *args, **kwargs):
+    def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 
 class IsCreateOnly(BasePermission):
     """Allows only create method."""
 
-    def has_permission(self, request, *args, **kwargs):
+    def has_permission(self, request, _view):
         return request.method == "POST"
 
-    def has_object_permission(self, request, view, *args, **kwargs):
+    def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 
 class IsUpdateOnly(BasePermission):
     """Allows only update method."""
 
-    def has_permission(self, request, *args, **kwargs):
+    def has_permission(self, request, _view):
         return request.method in ["PATCH", "PUT"]
 
-    def has_object_permission(self, request, view, *args, **kwargs):
+    def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 
@@ -72,7 +72,7 @@ class IsAuthenticated(IsAuthenticated):
     operator.
     """
 
-    def has_object_permission(self, request, view, *args, **kwargs):
+    def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 
@@ -154,7 +154,7 @@ def has_permission(self, request, view):
 
         return request.user.is_superuser
 
-    def has_object_permission(self, request, view, *args, **kwargs):
+    def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 

timed/projects/admin.py

@@ -95,7 +95,7 @@ class TaskInline(NestedStackedInline):
     extra = 0
     inlines = (TaskAssigneeInline,)
 
-    def has_delete_permission(self, *args, **kwargs):
+    def has_delete_permission(self, _request, _obj):
         # for some reason obj is parent object and not task
         # so this doesn't work
         return False

timed/subscription/views.py

@@ -99,7 +99,7 @@ def create(self, request, *args, **kwargs):
         methods=["post"],
         permission_classes=[IsSuperUser | IsAccountant],
     )
-    def confirm(self, request, *args, **kwargs):
+    def confirm(self, request, pk=None):  # noqa: ARG002
         """Confirm order.
 
         Only allowed by staff members
@@ -114,7 +114,7 @@ def confirm(self, request, *args, **kwargs):
     def get_queryset(self):
         return models.Order.objects.select_related("project")
 
-    def destroy(self, *args, **kwargs):
+    def destroy(self, _request, pk=None):  # noqa: ARG002
         instance = self.get_object()
         if instance.acknowledged:
             # acknowledge orders may not be deleted

timed/tracking/filters.py

@@ -45,7 +45,7 @@ class ActivityActiveFilter(Filter):
     """
 
     @boolean_filter
-    def filter(self, qs, *args, **kwargs):
+    def filter(self, qs, _value):
         """Filter the queryset.
 
         :param QuerySet qs: The queryset to filter

timed/tracking/views.py

@@ -191,7 +191,7 @@ def update(self, request, *args, **kwargs):
         methods=["get"],
         serializer_class=serializers.ReportIntersectionSerializer,
     )
-    def intersection(self, *args, **kwargs):
+    def intersection(self, _request):
         """Get intersection in reports of common report fields.
 
         Use case is for api caller to know what fields are the same