Skip to content

Commit

Permalink
feat(howto): document the Anbox VHAL HIDL integration into a VHAL imp…
Browse files Browse the repository at this point in the history
…lementation
  • Loading branch information
adglkh committed Nov 29, 2024
1 parent 318dfad commit f61f383
Show file tree
Hide file tree
Showing 2 changed files with 100 additions and 1 deletion.
7 changes: 6 additions & 1 deletion explanation/aaos.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ Until the 1.24.0 release, if you created your own VHAL implementation by followi

However, if a third-party VHAL implementation is loaded during Android runtime, on the Anbox Cloud Dashboard, some vehicle property values may still not be accessible while others may not be editable on the Anbox Cloud dashboard, due to [permission controls](https://source.android.com/docs/automotive/vhal/previous/properties#vehicle-props) that categorise vehicle properties as read-only, write-only, or read-write.

In the 1.24.1 release, Anbox Cloud will introduce an `IVehicle` HIDL interface that third-party VHAL implementations can use to modify non-writable vehicle property values or access non-readable vehicle property values. This will enable the Anbox VHAL adapter to communicate directly with the VHAL implementation that implements the `IVehicle` HIDL interface and manage those vehicle properties without facing permission issues.
Anbox Cloud offers an [Anbox-specific VHAL HIDL interface](https://github.com/canonical/vendor_canonical_interfaces). By implementing this HIDL, the VHAL implementation allows the Anbox VHAL adapter to

- modify non-writable vehicle property values.
- access non-readable vehicle property values.

without encountering permission issues.

## Related topics

Expand Down
94 changes: 94 additions & 0 deletions howto/android/custom-vhal.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,100 @@ addons:
- custom-vhal
```
## Integrate Anbox VHAL interface
To use and integrate the [Anbox VHAL interface](https://github.com/canonical/vendor_canonical_interfaces/tree/main/vehicle) into a VHAL implementation, the implementation must be built against Android 14. Before proceeding, ensure you have downloaded the Android 14 source. If you haven't done so yet, please follow the [official documentation](https://source.android.com/docs/setup/download) to set it up.
1. Add a new remote definition named `github` to `.repo/manifests/manifest.xml` file.

<remote name="aosp"
fetch=".."
review="https://android-review.googlesource.com/" />

<remote name="github"
fetch="https://github.com/canonical/" />

1. Add a new project named `vendor_canonical_interfaces` to the newly added remote and set it to use the `main` branch.

<project path="vendor/canonical/interfaces"
name="vendor_canonical_interfaces"
remote="github"
revision="main" />

1. Sync the project with the remote.

repo sync vendor_canonical_interfaces

1. In the VHAL implementation, create a VHAL manifest fragment named `[email protected]`.

<manifest version="1.0" type="device">
<hal format="hidl">
<name>vendor.canonical.interfaces.vehicle</name>
<transport>hwbinder</transport>
<fqname>@1.0::IVehicle/default</fqname>
</hal>
</manifest>

Place the VHAL manifest fragment file in the same folder as the `Android.bp` file that declares the VHAL service, and include the Anbox VHAL manifest fragment in the VHAL service declaration within the `Android.bp` file. Additionally, add the HIDL module as a shared library that the VHAL service links to in the `Android.bp` file.


cc_binary {
name: "vendor.<company>.vehicle@<version>-service",
vintf_fragments: [
...
"[email protected]",
],
shared_libs: [
...
"[email protected]",
],
...
}

1. Take the [example](https://github.com/canonical/vendor_canonical_interfaces/tree/main/vehicle/1.0/default) as a reference, which implements the `IVehicle` interface.

Return<void> VHalService::get(
const VehiclePropValue& requestedPropValue, IVehicle::get_cb _hidl_cb) {
uid_t uid = android::IPCThreadState::self()->getCallingUid();
if (uid != AID_VEHICLE_NETWORK) {
_hidl_cb(StatusCode::ACCESS_DENIED, kEmptyValue);
return Void();
}

// NOTE: a VHAL implementation must allow access to non-readable vehicle properties.
return Void();
}

Return<StatusCode> VHalService::set(const VehiclePropValue& value) {
uid_t uid = android::IPCThreadState::self()->getCallingUid();
if (uid != AID_VEHICLE_NETWORK)
return StatusCode::ACCESS_DENIED;

// NOTE: a VHAL implementation must allow modification of non-writable vehicle properties.
return StatusCode::NOT_AVAILABLE;
}

Please note that each function must implement a security mechanism to restrict access to vehicle properties to the authorised `AID_VEHICLE_NETWORK` process.

1. Instantiate the VHAL service that implements the interface and register it as a binder service in the VHAL implementation.

#include <VHalService.h>

int main(int /* argc */, char* /* argv */[]) {
...
...
configureRpcThreadpool(4, true);
auto vendor_vhal_service = std::make_unique<VHalService>();
status_t status = vendor_vhal_service->registerAsService();
if (status != OK) {
return 1;
}
joinRpcThreadpool();
return 1;
}

After implementing the Anbox HIDL interfaces and integrating them into your VHAL implementation, [build](https://source.android.com/docs/setup/build/building) the VHAL module. Then follow the instructions for [customising the Anbox VHAL](https://documentation.ubuntu.com/anbox-cloud/en/latest/howto/android/custom-vhal/) and load it as an addon during the Android runtime. Once registered, the service can be accessed by the Anbox VHAL adapter.

## Related topics

- {ref}`howto-create-addons`
Expand Down

0 comments on commit f61f383

Please sign in to comment.