Remove unnecessary dependencies #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dependency on The dependency on |
This conversion is done by Transpec 3.2.2 with the following command:
transpec
* 25 conversions
from: obj.should
to: expect(obj).to
* 21 conversions
from: == expected
to: eq(expected)
* 2 conversions
from: lambda { }.should
to: expect { }.to
* 1 conversion
from: collection.should have(n).items
to: expect(collection.size).to eq(n)
* 1 conversion
from: obj.should_not_receive(:message)
to: expect(obj).not_to receive(:message)
* 1 conversion
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
|
@benlangfeld thanks. I re-added the dependency on Adhearsion and set it to 3.0.0.rc1 |
|
|
||
| s.add_development_dependency "rspec", "~> 2.7.0" | ||
| s.add_development_dependency "rspec" |
There was a problem hiding this comment.
Why remove these version specs?
There was a problem hiding this comment.
I get the following error if I keep thor at "~> 0.14.0"
adhearsion-drb was resolved to 1.1.1, which depends on
adhearsion (> 3.0.0.rc1) was resolved to 3.0.0.rc1, which depends on> 0.18.0)
thor (
guard-rspec was resolved to 4.7.3, which depends on
guard (~> 2.1) was resolved to 2.14.0, which depends on
thor (>= 0.18.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes i18n and adhearsion as runtime dependencies. This helped me when using this plugin with the latest version of Adherasion