Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the contributors page and properly designed it. #511

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

tarunkumar2005
Copy link
Contributor

Issues Identification

Closes: #480

Description

I have properly done the contributors page and it is working super fine and good looking too and professional too. you can check in the image below

Types of Changes

Please check the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Please check the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes do not break the current system and pass all existing test cases
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots

image

image

@aditya-bhaumik Check this PR and merge it and assign this to me and put relevent labels like gssoc 2024 ext, hacktoberfest and level. i think it can be level 3 because the page is very important in open source to showcase the efforts of the people contributing in building it and it is not static it is dynamic as a new contributor is added to your repo it will be automatically added there so this is the beauty of this.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for pathsphere ready!

Name Link
🔨 Latest commit 52031e7
🔍 Latest deploy log https://app.netlify.com/sites/pathsphere/deploys/6708a3cbb49f2a00082741aa
😎 Deploy Preview https://deploy-preview-511--pathsphere.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, tarunkumar2005, for creating this pull request and contributing to Pathsphere! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@aditya-bhaumik
Copy link
Owner

how we are supposed to go back to the home page

@aditya-bhaumik
Copy link
Owner

where is the navbar and the footer is also different

@tarunkumar2005
Copy link
Contributor Author

Okay So i was just creating the contributors page if you want i can fix those things too will do that and update the PR @aditya-bhaumik

@aditya-bhaumik
Copy link
Owner

yes the contributor page needs to match the whole website layout

@aditya-bhaumik
Copy link
Owner

how will we get back to the main page share me a video

@aditya-bhaumik
Copy link
Owner

There is no navbar in your contributor page

@aditya-bhaumik
Copy link
Owner

also the footer is completely different then what other pages have

@aditya-bhaumik
Copy link
Owner

also where is the favicon

@tarunkumar2005
Copy link
Contributor Author

@aditya-bhaumik I am sorry for these mistakes i will fix these all soon but i usually work with react or next js so footer and navbars are automatically added and favicons are but no worries i will change all the things and update this PR thank you for clearly mentioning all the things. I will fix these soon if you find anything else in the page then you can tell that i will fix that also.

@tarunkumar2005
Copy link
Contributor Author

@aditya-bhaumik Check now.

@aditya-bhaumik aditya-bhaumik merged commit 0c5733e into aditya-bhaumik:main Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the contributors page to mention all the awersome people who have contributed to the website.
2 participants