-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Android Extension for Adobe Experience SDK v3 #1170
Adjust Android Extension for Adobe Experience SDK v3 #1170
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@shashanksu This is ready for review: |
src/content/docs/en/sdk/migration/adobe-extension/android/index.mdoc
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/adobe-extension/android/integration.mdoc
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/adobe-extension/android/integration.mdoc
Outdated
Show resolved
Hide resolved
@Sporiff Thanks for the PR. Docs looks nice 👍 Few minor comments: Integration guide:
Migration guide:
|
src/content/docs/en/sdk/migration/adobe-extension/android/index.mdoc
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/adobe-extension/android/global-parameters.mdoc
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/adobe-extension/android/global-parameters.mdoc
Outdated
Show resolved
Hide resolved
Love it! I made a few copy changes to appease Vale :-)
Would that work for all of our SKDs? |
Great, thanks!
Yep, I'd build it be generic. All we'd need is the permalink to the code in the GitHub repo. Leave the rest with me. |
@ironnysh @shashanksu I've added a new component for fetching example files from GitHub. We should now be able to copy the link to the file and have it appear as code in the documentation at build time. For example: https://dev-docs-git-adapp-18811-adobe-extension-de7bb9-product-content.vercel.app/en/sdk/adobe-extension/android/example |
@Sporiff Amazing, this is really nice 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related issues
Changes
This PR introduces the migration guide and documentation for the Adjust Android Extension for Adobe Experience SDK.
Required translations