Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Android Extension for Adobe Experience SDK v3 #1170

Merged
merged 28 commits into from
Nov 21, 2024

Conversation

Sporiff
Copy link
Contributor

@Sporiff Sporiff commented Oct 31, 2024

Related issues

Changes

This PR introduces the migration guide and documentation for the Adjust Android Extension for Adobe Experience SDK.

Required translations

Platform ZH JA KO
Android Adobe extension

@Sporiff Sporiff self-assigned this Oct 31, 2024
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 9:21am

@Sporiff Sporiff changed the title Adapp 18811 adobe extension android v3 update Adjust Android Extension for Adobe Experience SDK v3 Oct 31, 2024
@Sporiff Sporiff marked this pull request as ready for review October 31, 2024 15:12
@Sporiff
Copy link
Contributor Author

Sporiff commented Oct 31, 2024

@shashanksu This is ready for review:

@shashanksu
Copy link
Member

@shashanksu This is ready for review:

@Sporiff Thanks for the PR. Docs looks nice 👍 Few minor comments:

Integration guide:

dependencies {
  implementation 'com.adjust.adobeextension:adobeextension:3.0.0'
  implementation 'com.adjust.sdk:adjust-android:5.0.1'
}

Migration guide:

dependencies {
  implementation 'com.adjust.adobeextension:adobeextension:3.0.0'
  implementation 'com.adjust.sdk:adjust-android:5.0.1'
}

@ironnysh
Copy link
Contributor

I've updated this content to format it more like a set of guides.

Love it!

I made a few copy changes to appease Vale :-)

a component that directly fetches the example code from the repository

Would that work for all of our SKDs?

@Sporiff
Copy link
Contributor Author

Sporiff commented Nov 12, 2024

@ironnysh

I made a few copy changes to appease Vale :-)

Great, thanks!

Would that work for all of our SKDs?

Yep, I'd build it be generic. All we'd need is the permalink to the code in the GitHub repo. Leave the rest with me.

@Sporiff
Copy link
Contributor Author

Sporiff commented Nov 12, 2024

@ironnysh @shashanksu I've added a new component for fetching example files from GitHub. We should now be able to copy the link to the file and have it appear as code in the documentation at build time. For example: https://dev-docs-git-adapp-18811-adobe-extension-de7bb9-product-content.vercel.app/en/sdk/adobe-extension/android/example

@shashanksu
Copy link
Member

@ironnysh @shashanksu I've added a new component for fetching example files from GitHub. We should now be able to copy the link to the file and have it appear as code in the documentation at build time. For example: https://dev-docs-git-adapp-18811-adobe-extension-de7bb9-product-content.vercel.app/en/sdk/adobe-extension/android/example

@Sporiff Amazing, this is really nice 👏

Copy link
Contributor

@ironnysh ironnysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sporiff Sporiff merged commit 5144363 into main Nov 21, 2024
7 checks passed
@Sporiff Sporiff deleted the ADAPP-18811-adobe-extension-android-v-5-update branch November 21, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants