Merge pull request #18 from adjust/v121

Version 1.2.1
adjust · Jul 31, 2024 · b55ac85 · b55ac85
2 parents 12e4db0 + 95ece77
commit b55ac85
Show file tree

Hide file tree

Showing 8 changed files with 33 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+### Version 1.2.1 (1st August 2024)
+
+#### Fixed
+- Fixed an issue where calling `show` immediately after `init` when a network error occurred resulted in an infinite loop.
+- Added aria-label for dismiss button.
+
+---
+
 ### Version 1.2.0 (10th June 2024)
 
 #### Added

diff --git a/demo/package.json b/demo/package.json
@@ -10,8 +10,8 @@
     "test": "echo \"Error: no test specified\" && exit 1"
   },
   "dependencies": {
-    "@adjustcom/smart-banner-sdk": "^1.2.0",
-    "@adjustcom/smart-banner-sdk-layout": "^3.1.0",
+    "@adjustcom/smart-banner-sdk": "^1.2.1",
+    "@adjustcom/smart-banner-sdk-layout": "^3.1.1",
     "lorem-ipsum": "^2.0.8"
   },
   "author": "Adjust GmbH",

diff --git a/layout/package.json b/layout/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@adjustcom/smart-banner-sdk-layout",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "Adjust Smart Banner SDK Layout",
   "scripts": {
     "build": "npm run build:src && npm run build:types",

diff --git a/layout/src/dismiss-button/index.ts b/layout/src/dismiss-button/index.ts
@@ -10,6 +10,7 @@ export class DismissButton {
     this.button = document.createElement('button');
     this.button.innerHTML = cross;
     this.button.className = styles.dismiss;
+    this.button.ariaLabel = 'Close banner';
 
     const svg = this.button.querySelector('svg');
     if (svg) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@adjustcom/smart-banner-sdk-project",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Adjust Smart Banner SDK",
   "scripts": {
     "build": "npm run build --workspace=layout && npm run build --workspace=sdk && npm run build:snippet && npm run copy",

diff --git a/sdk/package.json b/sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@adjustcom/smart-banner-sdk",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Adjust Smart Banner SDK",
   "scripts": {
     "build:sdk": "webpack --config ./webpack.config.js",

diff --git a/sdk/src/domain/banner-provider.ts b/sdk/src/domain/banner-provider.ts
@@ -28,9 +28,11 @@ export class BannerProvider {
         }
 
         this.selectedBanner = this.selector.next(bannersList, url);
-        this.gettingBannerPromise = null;
 
         return this.selectedBanner;
+      })
+      .finally(() => {
+        this.gettingBannerPromise = null;
       });
 
     return this.gettingBannerPromise;