Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from palantir:develop #582

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 15, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Tests:

  • Skip tests that respect blueprintPortalClassName on legacy context and set active item to the selected item when the popover is closed.

@pull pull bot added the ⤵️ pull label Jan 15, 2025
Copy link

sourcery-ai bot commented Jan 15, 2025

Reviewer's Guide by Sourcery

This PR skips two failing tests resulting from the React 18 upgrade. The tests are skipped using it.skip instead of it. See issue palantir#7168 for more details.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Skip failing tests packages/core/test/portal/portalTests.tsx
packages/select/test/suggestTests.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@pull pull bot merged commit 07f1f48 into admariner:develop Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants