Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIF livesearch popover (Reference only) #319

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

CIF livesearch popover (Reference only) #319

wants to merge 34 commits into from

Conversation

rkdmen
Copy link
Member

@rkdmen rkdmen commented Aug 28, 2023 •
edited
Loading

Description

AEM+CIF / Livesearch popover (Reference only, Do not merge)
This PR is for reference of what file is needs to be update for livesearch popover.

Commented out search.js test searchbar.js to let build run.

Screenshots:

  • Desktop
image image
  • Mobile
image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@rkdmen rkdmen self-assigned this Aug 28, 2023
@rkdmen rkdmen requested a review from herzog31 August 28, 2023 15:54
@herzog31 herzog31 requested review from buuhuu and mhaack August 28, 2023 15:55
@rkdmen
Copy link
Member Author

rkdmen commented Aug 30, 2023

once https://github.com/magento-commerce/data-services-graphql/pull/17 is released to qa, will need to update this branch to get customer_group

@rkdmen rkdmen requested a review from priyasbhat August 30, 2023 20:17
buuhuu
buuhuu reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@buuhuu buuhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. Thanks for your contribution!

...s/src/main/content/jcr_root/apps/venia/components/commerce/searchbar/clientlibs/.content.xml Outdated Show resolved Hide resolved
ui.apps/src/main/content/jcr_root/apps/venia/components/commerce/searchbar/searchbar.html Outdated Show resolved Hide resolved
ui.tests/test-module/specs/venia/searchbar.js Outdated Show resolved Hide resolved
...rc/main/content/jcr_root/apps/venia/components/commerce/searchbar/clientlibs/js/searchbar.js Outdated Show resolved Hide resolved
...rc/main/content/jcr_root/apps/venia/components/commerce/searchbar/clientlibs/js/searchbar.js Outdated Show resolved Hide resolved
@rkdmen rkdmen requested a review from buuhuu September 6, 2023 17:40
@rkdmen rkdmen changed the title CIF livesearch popover (Do not merge) CIF livesearch popover (Reference only) Oct 4, 2023
@herzog31 herzog31 removed their request for review June 17, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaack mhaack Awaiting requested review from mhaack

@priyasbhat priyasbhat Awaiting requested review from priyasbhat

@buuhuu buuhuu Awaiting requested review from buuhuu

At least 1 approving review is required to merge this pull request.

Assignees

@rkdmen rkdmen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkdmen @buuhuu