Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to Main #100

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Staging to Main #100

merged 6 commits into from
Oct 8, 2024

Conversation

siddique-adobe
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

ishita-gambhir-adobe and others added 6 commits September 27, 2024 03:30
@ishita-gambhir-adobe
update updateProposition API to provide callback (#94)
5008841
@ishita-gambhir-adobe @akhiljain1907 @siddique-adobe
Provide errors and propositions in updateProposition callback (#96)
eae8807 
* handling of edge error response

* AEPOptimizeError callback error fixed using mappers

* add propositions to callback

* spotless apply

* add Adobe Errors

* add callbackt to test app

* fix checkstyle

* upgrade core version in testApp

* AEPOptimizeError mappers tests added

* 1. Core version of the project updated
2. Check style import issue fixed
3. AEPOptimizeErrorTest test fixed

* fix failing unit tests

---------

Co-authored-by: akhiljain1907 <[email protected]>
Co-authored-by: saquib-adobe <[email protected]>
@spoorthipujariadobe
Merge pull request #97 from adobe/dev-v3.1.0
524a698 
Dev v3.1.0 to Staging
@siddique-adobe
Version updated to 3.1.0
ad9b294
@spoorthipujariadobe
Merge pull request #98 from siddique-adobe/version-update
3583bf1 
Version updated to 3.1.0
@siddique-adobe
Merge pull request #99 from adobe/dev-v3.1.0
167b7c9 
Dev v3.1.0 to Staging
@spoorthipujariadobe spoorthipujariadobe self-requested a review October 8, 2024 17:33
@spoorthipujariadobe spoorthipujariadobe merged commit 4b8a92a into main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoorthipujariadobe spoorthipujariadobe spoorthipujariadobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddique-adobe @spoorthipujariadobe @ishita-gambhir-adobe