Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to Main #120

Merged
merged 47 commits into from
Dec 6, 2024
Merged

Staging to Main #120

merged 47 commits into from
Dec 6, 2024

Conversation

siddique-adobe
Copy link
Contributor

@siddique-adobe siddique-adobe commented Dec 6, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

ishwetansh and others added 30 commits September 10, 2024 11:54
Downgrade codecov to 3.2.4
MOB-21374 | Get proposition call will be dispatched immediately if all scopes are cached.
* Change the type of offer score from int to double

* fix failing unit test

* fix failing functional tests
documentation update for Offer Score datatype
siddique-adobe and others added 17 commits November 20, 2024 15:59
[MOB-22286] Updating `updatePropositions` and `getPropositions` public APIs for dynamic/configurable timeouts
Revert "documentation update for Offer Score datatype"
Revert "Change the type of offer score from int to double (#102)"
* add separate cache for preview propositions

* add tests

* run spotlessApply

* add functionality to clear preview cache

* address PR comments
[MOB-22521] Updating timeout scale to seconds from milliseconds in the updateProposition configurable timeout API
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 84.11215% with 17 lines in your changes missing coverage. Please review.

Project coverage is 83.42%. Comparing base (5b50e19) to head (632cba5).
Report is 122 commits behind head on main.

Files with missing lines Patch % Lines
...e/marketing/mobile/optimize/OptimizeExtension.java 81.52% 12 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #120      +/-   ##
============================================
- Coverage     86.14%   83.42%   -2.71%     
- Complexity        0      230     +230     
============================================
  Files             7        9       +2     
  Lines           743     1104     +361     
  Branches        122      177      +55     
============================================
+ Hits            640      921     +281     
- Misses           49      102      +53     
- Partials         54       81      +27     
Flag Coverage Δ
functional-tests 54.08% <41.12%> (-2.59%) ⬇️
unit-tests 81.34% <82.24%> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dobe/marketing/mobile/optimize/AEPOptimizeError.kt 83.05% <ø> (ø)
.../com/adobe/marketing/mobile/optimize/Optimize.java 76.06% <100.00%> (-6.54%) ⬇️
...e/marketing/mobile/optimize/OptimizeConstants.java 100.00% <ø> (ø)
...adobe/marketing/mobile/optimize/OptimizeUtils.java 83.33% <100.00%> (ø)
...e/marketing/mobile/optimize/OptimizeExtension.java 81.53% <81.52%> (-4.99%) ⬇️

... and 2 files with indirect coverage changes

@navratan-soni navratan-soni merged commit f927b25 into main Dec 6, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants