Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-21131] Display Proposition api to support multiple propositions. #112

Open
wants to merge 16 commits into
base: dev-v5.1.0
Choose a base branch
from

Conversation

akhiljain1907
Copy link
Contributor

Description

This PR adds an api "trackDisplayProposition" which takes list of proposition as an argument and sends display interaction event to Experience Edge.

Through this additional api, we now support display event to be called on multiple propositions which can be send in batches and not per offer (read: proposition) and so we've moved generateInteractionXDM and trackWithData methods from Offer class to public class.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ired for multiple propositions

moved generateInteractionXDM and trackWithData method from Offers class to public Optimize extension
added relevant OptimizePuiblicApiTests to validate code functioning for multiple propositions
…changed default value of aepError to unexpected
…sition]? instead of [DecisionScope]? in callback and code review changes
…ve AEPOptimizeError as argument and minor changes
@akhiljain1907 akhiljain1907 changed the base branch from dev-v5.0.2 to main September 24, 2024 19:56
@akhiljain1907 akhiljain1907 changed the base branch from main to dev-v5.0.2 September 24, 2024 19:57
@akhiljain1907 akhiljain1907 changed the base branch from dev-v5.0.2 to main September 25, 2024 09:38
@akhiljain1907 akhiljain1907 changed the base branch from main to dev-v5.0.2 September 25, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant