ASSETS-23937 - Support setting a color as background color #214
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 57.99% 56.95% -1.05%
==========================================
Files 12 12
Lines 819 834 +15
==========================================
Hits 475 475
- Misses 344 359 +15 ☔ View full report in Codecov by Sentry. |
tmathern
changed the title
| @@ -15,7 +15,7 @@ jobs: | |||
| if: "!contains(github.event.head_commit.message, '[ci skip]')" | |||
| strategy: | |||
| matrix: | |||
| node-version: [14.16.1, 14.17] | |||
| node-version: [14.17] | |||
There was a problem hiding this comment.
Dropping the oldest version.
I didn't update to a newer one because currently it breaks the test pipeline, since dependency hell in #213.
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "fmt": "png", | |||
| "pdfbgcolor": "#0EF" | |||
There was a problem hiding this comment.
This tests mimics adding a color as a background to any image with a transparent background
|
|
||
| function handleTransparency(img, instructions) { | ||
| if(instructions.pdfbgcolor) { |
There was a problem hiding this comment.
if we expect the supported format to be png then the condition should specify it.
if(instructions.pdfbgcolor && instructions.fmt === 'png') {
There was a problem hiding this comment.
at that point we'd support anything, since the whole imagemagick command will do the conversion. It's the input we expect to be PNG.
|
(Failing dependent tests expected, since the failing worker for PDF needs some adaptation to avoid double-processing) |
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
pdfbgcolor;Types of changes
Checklist: