fix(color-field): color handle positioning within scrollable containers #5322
+124
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d97332c The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
blunteshwar
changed the title
| position: relative; | ||
| } | ||
|
|
||
| sp-color-handle { |
There was a problem hiding this comment.
I just noticed sp-color-handle already has position: absolute set here: https://github.com/adobe/spectrum-web-components/blob/main/packages/color-handle/src/spectrum-color-handle.css#L48
So we can remove this rule and just leave the position: relative above 😄
Rajdeepc
approved these changes
Apr 3, 2025
| position: relative; | ||
| } | ||
|
|
||
| sp-color-handle { |
There was a problem hiding this comment.
does this not work adding to property to :host?
| @@ -61,6 +61,56 @@ viewColor.args = { | |||
| viewColor: true, | |||
| value: 'rgb(255,255,0)', | |||
| }; | |||
| export const Multiple = (args?: Properties): TemplateResult => { | |||
| // Array of predefined colors in different formats | |||
| const colors = [ | |||
There was a problem hiding this comment.
can you create a constant file for this?
Rajdeepc
changed the title
blunteshwar
changed the title
|
[DO NOT MERGE] Waiting for the new golden Image hash to be generated! |
blunteshwar
changed the title
rubencarvalho
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
The color handle in sp-color-field components was displaying in incorrect positions when multiple color fields were placed inside a scrollable container. As the container scrolled, the color handles would appear disconnected from their respective color fields, creating a poor user experience.
Root Cause
The issue occurred because absolutely positioned elements (like the sp-color-handle) require a positioned ancestor to establish their coordinate system. Since the position of sp-color-field(host) was by default
staticso without one, they position themselves relative to the nearest positioned ancestor (often the scrollable container itself), causing positioning inconsistencies during scrolling.Solution
Added position: relative to the :host selector in color-field.css
This simple change ensures that each color field component establishes its own positioning context, causing the color handle to position itself relative to its parent component sp-color-field rather than a distant ancestor.
Related issue(s)
#5109
Motivation and context
How has this been tested?
Test case 1
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Before
After
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.