Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166682 Migrate to Helix 5 #17

Merged
merged 2 commits into from
Feb 12, 2025
Merged

MWPW-166682 Migrate to Helix 5 #17

merged 2 commits into from
Feb 12, 2025

Conversation

meganthecoder
Copy link

@meganthecoder meganthecoder commented Feb 7, 2025

Copy link

aem-code-sync bot commented Feb 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 7, 2025

Page Scores Audits Google
📱 /blog/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /blog/?martech=off Timeout Exceeded PSI

Copy link

@JasonHowellSlavin JasonHowellSlavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know they added the SLD in utils in Milo for backwards compatibility. Do we need to worry about anything like that here.

@meganthecoder
Copy link
Author

I know they added the SLD in utils in Milo for backwards compatibility. Do we need to worry about anything like that here.

@JasonHowellSlavin No, I don't think so. There was nothing using the SLD variable in the PR that the Milo Core team put together adobecom/bacom#272 . We still need to support both .hlx. and .aem. when we set the milo libs, but that's already been taken care of.

@Dli3 Dli3 added the verified label Feb 12, 2025
@meganthecoder meganthecoder merged commit f52f350 into stage Feb 12, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants