[DX Adoption Fixes] Prevent Topics and Tags submissions without data #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* event format update prototyped * Update event-format-component-controller.js * topic tags design update * format topics interaction refined * community links component updated * wip * New fields for reg details finished * Toggle switch built for RSVP step * event type changes * Update registration-details-component-controller.js * fixing topics tag * fix format naming mistake * topics finished * Update event-format-component-controller.js * Update event-format-component-controller.js * small fixes * Update event-format-component-controller.js * venue and dup check fix * fallback with all series when filtering returned 0 * fix rsvp configs layout * more tooltips * Update event-format-component-controller.js * Decoupling done * new action button icons * fix import paths * linting * remove legacy divider code * fixing topics * DX-adoption fixes * send tag instead of name for industry tags * update login requirement language * Small refactor * removing extra populate series call * wip * step lock and topic population working * remove console log * Update controller.js * wip * wip * creativeCloud working without the correct topics list * DX to Experience Cloud update * Update allowGuestRegistration input * Update cmc.js * Update controller.js * Update controller.js
* Remove Template ID interfacing from Event level API calls * Update ecc-dashboard.js * Update series-templates-component.css
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #362 +/- ##
===========================================
- Coverage 67.22% 41.44% -25.79%
===========================================
Files 2 2
Lines 238 374 +136
===========================================
- Hits 160 155 -5
- Misses 78 219 +141 ☔ View full report in Codecov by Sentry. |
qiyundai
added a commit
that referenced
this pull request
Feb 10, 2025
…362) * fixing lana.log typo errors * DX adoption ECC changes (#283) * event format update prototyped * Update event-format-component-controller.js * topic tags design update * format topics interaction refined * community links component updated * wip * New fields for reg details finished * Toggle switch built for RSVP step * event type changes * Update registration-details-component-controller.js * fixing topics tag * fix format naming mistake * topics finished * Update event-format-component-controller.js * Update event-format-component-controller.js * small fixes * Update event-format-component-controller.js * venue and dup check fix * fallback with all series when filtering returned 0 * fix rsvp configs layout * more tooltips * Update event-format-component-controller.js * Decoupling done * new action button icons * fix import paths * linting * remove legacy divider code * fixing topics * DX-adoption fixes * send tag instead of name for industry tags * update login requirement language * Small refactor * removing extra populate series call * wip * step lock and topic population working * remove console log * Update controller.js * wip * wip * creativeCloud working without the correct topics list * DX to Experience Cloud update * Update allowGuestRegistration input * Update cmc.js * Update controller.js * Update controller.js * Remove Template ID interfacing from Event level API calls (#355) * Remove Template ID interfacing from Event level API calls * Update ecc-dashboard.js * Update series-templates-component.css * Prevent submission without data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your specific features or fixes and provide a preview link for the feature being incorporated
Resolves: MWPW-155175
Test URLs:
To test the feature, please load up the branch locally and run it against your local ESP and ESL server.
For more information on how to set up ESL and ESP locally, please refer to: FE Dev Wiki