-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage to Main Release #144
base: main
Are you sure you want to change the base?
Conversation
…-issue Mobile: How to steps carousel block not centered for DE pages.
Port FaqV2 Block To Milo From Express
Premium CTA Gradient
Card accessibility fix
* Update mobile-fork-button-frictionless.css * Update mobile-fork-button.css * updated remaining files
* Update template-ckg.js * Update template-ckg.js * lint * Update template-ckg.js * Update template-ckg.js
Adding accessible name to gen ai input
MWPW-164914 - Accessibility contrast ratio
Header Overflow Fix
Accessible pricing tooltip
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me the faqv2 block looks like it still needs a little work , especially since it's new and should probably be up to snuff when rolling out.
things like setting the innerHTML on line 6 of the JS file to an empty string is bad practice since it's bad for performance and kills any listeners that were previously on links for example, or that whole moving the header out of the block shenanigans on line 14 seems very strange to me. Those are the precise types of antipatterns that I'm hoping Express can now avoid, now that it's on milo.
I'd personally revert that part, and the rest looks pretty good imo.
Revert "Port FaqV2 Block To Milo From Express"
Release of the following:
#127
#131
#134
#136
#138
#140
#141
#142
#143
Test URLs: