Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage to Main Release #144

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Stage to Main Release #144

wants to merge 46 commits into from

Conversation

fullcolorcoder
Copy link
Collaborator

@fullcolorcoder fullcolorcoder commented Jan 29, 2025

jsandland and others added 30 commits January 8, 2025 12:35
…-issue

Mobile: How to steps carousel block not centered for DE pages.
Port FaqV2 Block To Milo From Express
Ryan Clayton and others added 13 commits January 28, 2025 12:02
* Update mobile-fork-button-frictionless.css

* Update mobile-fork-button.css

* updated remaining files
* Update template-ckg.js

* Update template-ckg.js

* lint

* Update template-ckg.js

* Update template-ckg.js
MWPW-164914 - Accessibility contrast ratio
Copy link

aem-code-sync bot commented Jan 29, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 29, 2025

Page Scores Audits
📱 /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the faqv2 block looks like it still needs a little work , especially since it's new and should probably be up to snuff when rolling out.

things like setting the innerHTML on line 6 of the JS file to an empty string is bad practice since it's bad for performance and kills any listeners that were previously on links for example, or that whole moving the header out of the block shenanigans on line 14 seems very strange to me. Those are the precise types of antipatterns that I'm hoping Express can now avoid, now that it's on milo.

I'd personally revert that part, and the rest looks pretty good imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants