Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cc everywhere variant param v2 #243

Open
wants to merge 15 commits into
base: stage
Choose a base branch
from

Conversation

echen-adobe
Copy link
Collaborator

@echen-adobe echen-adobe commented Mar 11, 2025

Describe your specific features or fixes

Adds an option to load a full editor in place for remove background pages. Can be currently triggered by specifying the frictionless QA action typevariant=qa-in-product-variant1 and variant=qa-in-product-variant2 in the document.

Resolves: https://jira.corp.adobe.com/projects/MWPW/issues/MWPW-167750

Test Instructions
Visit urls below and use the remove background feature. URLs 2 and 3 should have a different editor that takes up a full screen compared to urls 1 and 4.

Also, check the page without any of the URL arguments.

Test URLs:

@echen-adobe echen-adobe added the do not merge Use if business reason for not merging. label Mar 11, 2025
Copy link

aem-code-sync bot commented Mar 11, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 16:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 16:50 Inactive
@echen-adobe echen-adobe added Ready for Review Ready for peer review. and removed do not merge Use if business reason for not merging. labels Mar 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 17.39130% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.98%. Comparing base (ace42de) to head (9f5d1af).
Report is 37 commits behind head on stage.

Files with missing lines Patch % Lines
...tionless-quick-action/frictionless-quick-action.js 17.39% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #243      +/-   ##
==========================================
- Coverage   67.25%   66.98%   -0.28%     
==========================================
  Files          62       62              
  Lines       10298    10303       +5     
==========================================
- Hits         6926     6901      -25     
- Misses       3372     3402      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

added new file as an experiment
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 17:30 Inactive
@echen-adobe echen-adobe added do not merge Use if business reason for not merging. and removed Ready for Review Ready for peer review. labels Mar 11, 2025
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 18:03 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 18:30 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 18:31 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 19:04 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 19:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 11, 2025 20:32 Inactive
commit 3e2d3ef
Author: echen-adobe <[email protected]>
Date:   Wed Mar 12 08:37:24 2025 -0700

    Update frictionless-quick-action.js

commit 14e8d85
Author: echen-adobe <[email protected]>
Date:   Wed Mar 12 08:36:17 2025 -0700

    Update frictionless-quick-action.js

commit 67b2bbf
Author: echen-adobe <[email protected]>
Date:   Wed Mar 12 08:34:53 2025 -0700

    Update frictionless-quick-action.js

commit 6429bfa
Author: echen-adobe <[email protected]>
Date:   Wed Mar 12 08:30:49 2025 -0700

    Update frictionless-quick-action.js

commit e8f1b52
Author: echen-adobe <[email protected]>
Date:   Tue Mar 11 13:50:29 2025 -0700

    Update frictionless-quick-action.js

commit 3625016
Author: echen-adobe <[email protected]>
Date:   Tue Mar 11 13:48:54 2025 -0700

    Update frictionless-quick-action.js

commit 5b8315c
Author: echen-adobe <[email protected]>
Date:   Tue Mar 11 13:43:08 2025 -0700

    Update frictionless-quick-action.js

commit ed0361f
Author: echen-adobe <[email protected]>
Date:   Tue Mar 11 13:42:04 2025 -0700

    Update frictionless-quick-action.js

commit 809f0e8
Author: echen-adobe <[email protected]>
Date:   Tue Mar 11 13:39:52 2025 -0700

    Update frictionless-quick-action.js

commit 10a0030
Author: echen-adobe <[email protected]>
Date:   Tue Mar 11 13:38:03 2025 -0700

    Update frictionless-quick-action.js
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 12, 2025 15:46 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to cc-everywhere-variant-param-v2 March 12, 2025 15:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Use if business reason for not merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants