Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-169165] Added Authorable Labels to Grid Marquee #246

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

JingleH
Copy link
Collaborator

@JingleH JingleH commented Mar 12, 2025

  • Allow authors to use italics to add labels to grid-marquee cards.
  • Slight refactoring

Resolves: https://jira.corp.adobe.com/browse/MWPW-169165

Test URLs:

How to test:

  • Hover over the third card "Create fast with...", and you should see the labels being added.
  • All other features of this block should remain the same

Copy link

aem-code-sync bot commented Mar 12, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Mar 12, 2025

Page Scores Audits
📱 /drafts/jingle/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /drafts/jingle/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.51%. Comparing base (1d7887e) to head (a8cddbd).
Report is 42 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #246      +/-   ##
==========================================
+ Coverage   67.12%   67.51%   +0.39%     
==========================================
  Files          63       61       -2     
  Lines       10353    10148     -205     
==========================================
- Hits         6949     6851      -98     
+ Misses       3404     3297     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants