Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2179

Merged
merged 5 commits into from
Apr 23, 2024
Merged

[Release] Stage to Main #2179

merged 5 commits into from
Apr 23, 2024

Conversation

Ruchika4
Copy link
Contributor

@Ruchika4 Ruchika4 commented Apr 22, 2024 •
edited by drashti1712
Loading

Blainegunn and others added 2 commits April 22, 2024 10:27
@Blainegunn
MWPW-146756] Add support for RTL in aside notifications, horizontal c…
513fba6 
…ards"" (#2178)

Revert "Revert "[MWPW-146756] Add support for RTL in aside notifications, hor…"

This reverts commit 76bcdbc.
@Axelcureno @yesil
Mwpw 142003: Mini Compare Chart card fixes (#2093)
443d511 
Fixes multiple Mini Compare Chart card alignment and spacing issues.

Resolves: MWPW-142003

Note: Alignment across cards will show broken in test URL because prices are not resolved due to CORS policy. To properly test alignment, please use this URL: https://main--cc--adobecom.hlx.page/drafts/axel/mini-compare-chart-edgecase?milolibs=MWPW-142003--milo--axelcureno

Test URLs:

Before: https://main--milo--axelcureno.hlx.page/drafts/axel/mini-compare-chart?martech=off
After: https://mwpw-142003--milo--axelcureno.hlx.page/drafts/axel/mini-compare-chart?martech=off

Co-authored-by: ilyas Stéphane Türkben <[email protected]>
@Ruchika4 Ruchika4 added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs high priority Why is this a high priority? Blocker? Critical? Dependency? labels Apr 22, 2024
@Ruchika4 Ruchika4 requested review from a team April 22, 2024 17:30
@Ruchika4 Ruchika4 requested review from a team and Sartxi as code owners April 22, 2024 17:30
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 22, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.69%. Comparing base (76bcdbc) to head (791778c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
+ Coverage   96.63%   96.69%   +0.05%     
==========================================
  Files         165      165              
  Lines       43499    43485      -14     
==========================================
+ Hits        42035    42047      +12     
+ Misses       1464     1438      -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ruchika4 Ruchika4 requested a review from a team as a code owner April 23, 2024 00:03
@Ruchika4
Copy link
Contributor Author

@Roycethan @JackySun9 @tedAir @Dli3 @sigadamvenkata
PR #2181 got merged to stage before this already approved PR could get merged in main because of an urgent issue on production. This just reverts the code merged in PR #2059

Could you please help do a quick round of check again.

cc @Blainegunn @ryanmparrish @rgclayton @narcis-radu @drashti1712 @3ch023

@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@Roycethan
Copy link

@Roycethan @JackySun9 @tedAir @Dli3 @sigadamvenkata PR #2181 got merged to stage before this already approved PR could get merged in main because of an urgent issue on production. This just reverts the code merged in PR #2059

Could you please help do a quick round of check again.

cc @Blainegunn @ryanmparrish @rgclayton @narcis-radu @drashti1712 @3ch023

ok re-verified on stage - apart from an issue (causing due to a CDN change ) but not related to this PR , ok from home page side.
For everyone's reference marking here: https://jira.corp.adobe.com/browse/WPS-25099?focusedCommentId=41296503&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-41296503

@JackySun9 JackySun9 self-requested a review April 23, 2024 02:28
@sharmrj
MWPW-146129 App Launcher overlaps the menu in Unav in the devices (#2123
743ce09 
)

* Closes the global nav expanded wrapper in non desktop viewports when the user interacts with the universal nav (Notifications, app switcher, and profile/sign in button)

* We no longer use element.click

* made toggleMenuMobile a method of the Gnav class

* Extracted the toggle expanded check into its own function

* a little cleanup
@drashti1712 drashti1712 added the do not merge PR should not be merged yet label Apr 23, 2024
@drashti1712
Copy link
Contributor

Adding do-not-merge as another PR merged to stage(#2123) has been added to this. We might need to revert the stage PR or re-verify the changes on this one. Waiting for confirmation on the same.
@salonijain3 @overmyheadandbody @Blainegunn @Ruchika4

@drashti1712
Revert "MWPW-146129 App Launcher overlaps the menu in Unav in the dev…
791778c 
…ices" (#2182)

Revert "MWPW-146129 App Launcher overlaps the menu in Unav in the devices (#2…"

This reverts commit 743ce09.
@salonijain3 salonijain3 removed the do not merge PR should not be merged yet label Apr 23, 2024
@salonijain3
Copy link
Contributor

Do not merge label has been removed, as the other PR on stage has been reverted and will be raised after this PR goes to main as per the process.

@drashti1712 drashti1712 merged commit 63a752e into main Apr 23, 2024
15 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Closed
@mokimo mokimo mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmparrish ryanmparrish ryanmparrish approved these changes

@tedAir tedAir tedAir approved these changes

@Sartxi Sartxi Sartxi approved these changes

@Dli3 Dli3 Dli3 approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Roycethan Roycethan Roycethan approved these changes

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@overmyheadandbody overmyheadandbody Awaiting requested review from overmyheadandbody

@mokimo mokimo Awaiting requested review from mokimo

@narcis-radu narcis-radu Awaiting requested review from narcis-radu

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 DC SOT 👌 high priority Why is this a high priority? Blocker? Critical? Dependency? Homepage SOT 👌 MIQ SOT👌 needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.