Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2208

Merged
merged 4 commits into from
Apr 29, 2024
Merged

[Release] Stage to Main #2208

merged 4 commits into from
Apr 29, 2024

Conversation

Ruchika4
Copy link
Contributor

@Ruchika4 Ruchika4 commented Apr 25, 2024 •
edited by vladen
Loading

narcis-radu and others added 3 commits April 25, 2024 10:31
@narcis-radu @Blainegunn @robert-bogos
Update code owners for feds (#2194)
f18c399 
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
@rgclayton
Harden preflight link checking (#2169)
8ee620d 
* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <[email protected]>
@Axelcureno
MWPW-146755: RTL merch icon padding (#2162)
f847222 
* RTL padding merch icon

* dep update
@Ruchika4 Ruchika4 added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs labels Apr 25, 2024
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 25, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (1332031) to head (dac9c7e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
- Coverage   96.65%   96.65%   -0.01%     
==========================================
  Files         165      165              
  Lines       43525    43533       +8     
==========================================
+ Hits        42069    42076       +7     
- Misses       1456     1457       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@npeltier
MWPW-146001 parallelize literals call (#2187)
dac9c7e 
* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut
@Ruchika4 Ruchika4 requested a review from a team as a code owner April 26, 2024 14:07
@vladen vladen requested a review from Roycethan April 26, 2024 14:35
@aem-code-sync aem-code-sync bot temporarily deployed to project-pep-prep April 29, 2024 11:06 Inactive
@vhargrave vhargrave merged commit 7f196f5 into main Apr 29, 2024
27 of 28 checks passed
Blainegunn added a commit that referenced this pull request Apr 29, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier
MWPW-137282 - Action item block layout options (#1501)
b7e8900 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (#2208)

* Update code owners for feds (#2194)

Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>

* Harden preflight link checking (#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <[email protected]>

* MWPW-146755: RTL merch icon padding (#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>

---------

Co-authored-by: Ruchika Sinha <[email protected]>
Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier @mokimo
MWPW-137282 - Action item block layout options (adobecom#1501)
f1158ec 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (adobecom#2208)

* Update code owners for feds (adobecom#2194)

Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>

* Harden preflight link checking (adobecom#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <[email protected]>

* MWPW-146755: RTL merch icon padding (adobecom#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (adobecom#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>

---------

Co-authored-by: Ruchika Sinha <[email protected]>
Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier @mokimo
MWPW-137282 - Action item block layout options (adobecom#1501)
fc54e9a 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (adobecom#2208)

* Update code owners for feds (adobecom#2194)

Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>

* Harden preflight link checking (adobecom#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <[email protected]>

* MWPW-146755: RTL merch icon padding (adobecom#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (adobecom#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>

---------

Co-authored-by: Ruchika Sinha <[email protected]>
Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier @mokimo
MWPW-137282 - Action item block layout options (adobecom#1501)
8fb330f 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (adobecom#2208)

* Update code owners for feds (adobecom#2194)

Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>

* Harden preflight link checking (adobecom#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <[email protected]>

* MWPW-146755: RTL merch icon padding (adobecom#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (adobecom#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>

---------

Co-authored-by: Ruchika Sinha <[email protected]>
Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Axel Cureno Basurto <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narcis-radu narcis-radu narcis-radu approved these changes

@rgclayton rgclayton rgclayton approved these changes

@tedAir tedAir tedAir approved these changes

@vladen vladen vladen approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@mokimo mokimo mokimo approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Roycethan Roycethan Roycethan approved these changes

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@Blainegunn Blainegunn Awaiting requested review from Blainegunn

Assignees
No one assigned
Labels
CC SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌 needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.