-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-167856: Update merch sidenav component to reflect hash changes #3696
MWPW-167856: Update merch sidenav component to reflect hash changes #3696
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (with eventual UT coverage ;) )
@mirafedas |
Reminder to set the |
@Roycethan from what I see, this bug exists on main: https://main--cc--adobecom.hlx.page/products/catalog , can we create a separate Jira for it? Just to get this PR merged before the RCP |
@mirafedas Yes its exist in main and its part of the ticket thats being raised by them. the last batch before RCP is already in and no more PRs will be merged this week and next, so we have time time to fix, and stakeholders mentioned this is low risk based on analytics results. |
@Roycethan fixed, ready to be checked 👍 |
Thanks @mirafedas Fixed |
Skipped 3696: "MWPW-167856: Update merch sidenav component to reflect hash changes" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch |
Skipped 3696: "MWPW-167856: Update merch sidenav component to reflect hash changes" due to file "libs/deps/mas/commerce.js" overlap. Merging will be attempted in the next batch |
Error merging 3696: MWPW-167856: Update merch sidenav component to reflect hash changes Pull Request is not mergeable |
With this PR the merch-sidenav-list and merch-sidenav-checkbox-group web components reflect the hash changes: when we change the value in the hash, the components will update accordingly.
Resolves: MWPW-167856
Test URLs:
For QA:
Page: https://main--cc--adobecom.hlx.page/drafts/mirafedas/catalog?milolibs=mwpw-167856-sidenav-deeplink-hash--milo--mirafedas
Click the 'All PDF products' CTA located on the marquee - it works the same way as the link in gnav.