Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-167856: Update merch sidenav component to reflect hash changes #3696

Merged

Conversation

mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Feb 17, 2025

With this PR the merch-sidenav-list and merch-sidenav-checkbox-group web components reflect the hash changes: when we change the value in the hash, the components will update accordingly.

Resolves: MWPW-167856

Test URLs:

For QA:
Page: https://main--cc--adobecom.hlx.page/drafts/mirafedas/catalog?milolibs=mwpw-167856-sidenav-deeplink-hash--milo--mirafedas
Click the 'All PDF products' CTA located on the marquee - it works the same way as the link in gnav.

Copy link
Contributor

aem-code-sync bot commented Feb 17, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (with eventual UT coverage ;) )

@Roycethan
Copy link

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@mirafedas
Copy link
Contributor Author

mirafedas commented Feb 20, 2025

@Roycethan from what I see, this bug exists on main: https://main--cc--adobecom.hlx.page/products/catalog , can we create a separate Jira for it? Just to get this PR merged before the RCP
Screenshot 2025-02-20 at 14 25 07

@Roycethan
Copy link

@Roycethan from what I see, this bug exists on main: https://main--cc--adobecom.hlx.page/products/catalog , can we create a separate Jira for it? Just to get this PR merged before the RCP Screenshot 2025-02-20 at 14 25 07

@mirafedas Yes its exist in main and its part of the ticket thats being raised by them. the last batch before RCP is already in and no more PRs will be merged this week and next, so we have time time to fix, and stakeholders mentioned this is low risk based on analytics results.

@mirafedas mirafedas changed the title MWPW-167856: Update merch-sidenav-list component to reflect hash changes MWPW-167856: Update merch sidenav component to reflect hash changes Feb 27, 2025
@mirafedas
Copy link
Contributor Author

@Roycethan fixed, ready to be checked 👍

@Roycethan
Copy link

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Feb 27, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Mar 3, 2025

Skipped 3696: "MWPW-167856: Update merch sidenav component to reflect hash changes" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Mar 4, 2025

Skipped 3696: "MWPW-167856: Update merch sidenav component to reflect hash changes" due to file "libs/deps/mas/commerce.js" overlap. Merging will be attempted in the next batch

@3ch023 3ch023 added the commerce label Mar 4, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Mar 6, 2025

Error merging 3696: MWPW-167856: Update merch sidenav component to reflect hash changes Pull Request is not mergeable

@milo-pr-merge milo-pr-merge bot merged commit a452751 into adobecom:stage Mar 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants