MWPW-167207: Plans card pixel perfect #3704
Conversation
…3663) Co-authored-by: Bozo Jovicic <[email protected]>
# Conflicts: # libs/deps/mas/mas.js # libs/deps/mas/merch-card.js # libs/features/mas/dist/mas.js # libs/features/mas/src/variants/plans.css.js
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
|
hey @st-angelo-adobe , I noticed some visual issues. Please see the figma specs, I think the info icon should still be top right and the info container should have different sizing. |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
libs/deps/mas/mas.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/dist/mas.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/global.css.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Resolves: MWPW-167207
Test URLs:
Before: https://mwpw-164492--milo--adobecom.aem.page/docs/library/kitchen-sink/merch-card?martech=off
After: https://mwpw-167207--milo--adobecom.aem.page/docs/library/kitchen-sink/merch-card?martech=off
Plans Gallery:
mwpw-167207--milo--adobecom.aem.page/libs/features/mas/docs/plans.html?martech=off